• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

EditTablePlugin in Dakar SVN is from 10 Dec 2005 and was based on a version from 05 Mar 2005.

The version from TWiki.org is 16 Sep 2004.

Several updates and features have been missed.

The result is that quite many TWikApplications fail when upgrading to Dakar because EditTablePlugin is very popular. For example radio buttons are heavily used.

The version from Twiki.org should be put on SVN and the CSS update applied to it.

KJL

Forgot to select Extension field

I compared the Twiki.org version and the SVN version.

The SVN version is totally out of date. There is a factor 10 more code in the TWiki.org version. I tried to compare the two to see if it was easy for me to patch the changes done on the SVN version to the TWiki.org version but the TWiki.org version is a complete rewrite. The TWiki.org version also uses one of the deprecated handlers. So this is way above my skill level.

KJL


Did you mean "The version from TWiki.org is 16 Sep 2005 "? I'm confused.....

According to svn log, the most recent synchronisation was:

r4975 | maphew | 2004-05-06 21:29:55 +0100 (Thu, 06 May 2004) | 4 lines

*non-maintainer update* synchronized with released zip version,  which was ahead of the cvs version
Internal plugin version: 07 Apr 2004
Zip version: 1.20 (http://twiki.org/cgi-bin/viewfile/Plugins/EditTablePlugin?rev=1.20&filename=EditTablePlug
in.zip)

CC

No 2004.

So the CVS version must have been really old.

The SVN version lacks this changes.

16 Sep 2004 Added radio buttons and checkbox controls; escaped "|" pipe symbol found in input fields to preserve tables

And it is pretty important because it is a major feature enhancement. Both radio buttons, checkbox controls are heavily used - and quite smart in a TWiki App I may add.

On the SVN version these two changes have been made.

10 Dec 2005 Added css class names to enable custom styling; see for instance PatternSkinCssCookbookEditTableStyle
05 Mar 2005 1.024 Crawford Currie changed to use JSCalendarContrib and prepped for Dakar release

So it is not that trivial a merge to do. But since this is one of the essential plugins it should be done before release. I can do a lot of testing of it the next days if the merge is done to make sure the result is robust.

KJL

OK, I merged in the changes from the zip. Note that there doesn't seem to be any kind of tests for the plugin, even in the plugin topic; it might be an idea to generate a suitable test topic to make future merges easier.

SVN 8405

CC

Thanks Crawford!

-- PTh

ItemTemplate
Summary EditTablePlugin is an updated OLD version
ReportedBy TWiki:Main.KennethLavrsen
Codebase

SVN Range Thu, 19 Jan 2006 build 8384
AppliesTo Extension
Component EditTablePlugin
Priority Urgent
CurrentState Closed
WaitingFor

Checkins 8405 8414
Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2006-01-21 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback