• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Issue found in Item1395: It is not possible to have this content in a template topic, such as NewUserTemplate:

%NOP{
   * Any %VARIABLE%{with parameters}%
   * Such as %MAKETEXT{foobar}%
}%

If you instantiate a topic based on a template topic containing above content, TWiki will strip away the %NOP% up to the first }% found.

How to reproduce:

1. Create Sandbox.WebTopicEditTemplate with this content:

%NOP{
   * %MAKETEXT{OK}%
this text should disappear in an instantiated topic
}%---+!! Topic Title

2. Create new topic in Sandbox web. It should show just a title ---+!! Topic Title, but contains this text should disappear in an instantiated topic %7d%---+!! Topic Title. See example Sandbox.TestTopic36

The correct behaviour is to make NOP aware of variable nesting.

For Dakar release, either this bug needs to be fixed, or a workaround found for Item1395.

-- PTh

Correct; this behaviour is the same as Cairo (I just checked), largely because the code that handles this is unchanged from Cairo (NOP isn't handled by the parser, it's one of those nasty s/.*?//gs expressions).

This is an excellent opportunity to get rid of another context dependency. However the fix is quite complex, and will require careful verification.

CC

Now is always a great time to embark on the adventure of a lifetime smile

Perhaps do this in a seperate branch, for starters?

-- SP

Fixed in SVN 8345

CC

Amazing, seems to work sofar, nifty work. Will continue testing a bit.

- When I grow up, I want to be a great perl hacker, like CC! smile

-- SP

Thanks for resolving this so quickly.

-- PTh

Note that the behaviour after this fix (which was in beta 6) has now broken some TWiki applications.

See the discussion on Item1432.

My gut tells me that on balance the damage to existing apps is far worse than the damage from having this bug hand over from Cairo.

CC

Yes, please revert the changes in SVN 8345.

MD

OK, this is effectively unfixable. The definition of TML does not allow for balancing open/close tags inside a NOP; the problem existed in Cairo as well. See Item1432 for more on this.

Full fix reverted in SVN 8380, though the test example given above should be OK (because %MAKETEXT expands validly during tag expansion).

CC

This breaks registration again, see and follow-up in Item1452

-- PTh

ItemTemplate
Summary NOP{} cannot contain variables with parameters
ReportedBy PeterThoeny
Codebase

SVN Range Sat, 14 Jan 2006 build 8289
AppliesTo Engine
Component

Priority Urgent
CurrentState Closed
WaitingFor

Checkins 8343 8345
Edit | Attach | Watch | Print version | History: r14 < r13 < r12 < r11 < r10 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r14 - 2006-01-20 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback