• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Test cases:

http://svn.twiki.org/do/search/Sandbox/?search=variable;skin=plain
http://svn.twiki.org/do/search/Sandbox/?search=variable;skin=text
http://svn.twiki.org/do/search/Sandbox/?search=variable;skin=foobar

The last one works OK since he skin does not exist.

Compare with Cairo:

http://twiki.org/cgi-bin/search/Sandbox/?search=variable;skin=plain
http://twiki.org/cgi-bin/search/Sandbox/?search=variable;skin=text
http://twiki.org/cgi-bin/search/Sandbox/?search=variable;skin=foobar

-- PTh

This is nothing to do with skin fallback. The template file is wrong somehow. Item1300 is a better report of the same thing.

CC

Thanks for fixing
http://svn.twiki.org/do/search/Sandbox/?search=variable;skin=plain

But why does this not work?
http://svn.twiki.org/do/search/Sandbox/?search=variable;skin=text

-- PTh

search.tmpl is defined to include view.tmpl. When skin=text that means it includes view.text.tmpl, which is defined as just %TEXT%, so it has no %SPLIT% tags. I removed view.text.tmpl, but Antonio put it back; apparently he has some applications that depend on it. For the text skin to work with search it needs to define search.text.tmpl. I added one, though I can't imagine why you would want to use it.

Note: the whole approach of using %SPLIT% tags is horrible. It would have been much better to instantiate specific templates. i.e. instead of:

my( $tmplHead, $tmplSearch, $tmplTable, $tmplNumber, $tmplTail ) = split( /%SPLIT%/, $tmpl );
it should use
my $tmplHead = $templates->expandTemplate("SEARCH:header");
my $tmplSearch = $templates->expandTemplate("SEARCH:search");
etc
This approach makes the whole thing a lot less sensitive to the structure templates, and a lot easier to debug. I didn't change the code in DakarRelease, though, for fear of breaking existing skins. Now I wish I had. Ho hum.

CC

ItemTemplate
Summary Skin fallback not woking
ReportedBy PeterThoeny
Codebase

SVN Range Mon, 02 Jan 2006 build 8065
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 8102 8103
Edit | Attach | Watch | Print version | History: r6 < r5 < r4 < r3 < r2 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r6 - 2006-01-05 - CrawfordCurrie
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback