• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.

Test case:

  • %ICON{zip}% : Compressed Zip archive
  • %ICONURL{zip}% : http://svn.twiki.org/pub/TWiki/TWikiDocGraphics/zip.gif

-- PTh

You mean it should generate a relative path? What's wrong with a full url?

AC

It should be consistent with PUBURLPATH, ATTACHURLPATH, SCRIPTURLPATH, e.g. should omit the protocol and host.

-- PTh

It means something quite different, as I understand it from the documentation. %ICON generates an actual icon image, whereas %ICONPATH (note: not ICONURLPATH) generates a URL. The choice of ICONPATH as a name for the function is unfortunate, though I'm not sure what else could have been used. Possibly ICONURL would have been better, but it's too late to change now IMHO.

CC

That explains it. I do not think it is too late to change the name since Dakar is not release yet. We can't break rendering between production releases, but it is OK to change the spec of alpha and beta releases.

The current name ICONPATH is very confusing, see also Item1277.

So, lets rename the ICONPATH variable to ICONURL. (Renamed title of this bug entry accordingly)

-- PTh

Peter, with 'orthogonal', do you mean 'in a different direction'? My dictionary says "of or involving right angles; at right angles." so I understand this as "directly opposed to".

But I am sure you mean that it should use the same name format, xxxURLPATH. I don't have a problem to rename ICONPATH to ICONURLPATH. Better now than never.

AC

People are constantly confused by the way Peter uses the word. "Orthogonal" means, literally, "lying at right angles to each other". To most people this suggests "two things which are opposed" or "heading in different directions". However Peter uses it as "lying in the same plane". My in-built auto-translator converts Peter's uses of "orthogonal to" "consistent with" and that seems to work fairly consistently (as long as you remember to translate).

And no, he doesn't mean rename to ICONURLPATH. The consistent usage is:

  • *URL variables generate absolute URLs (SCRIPTURL=http://svn.twiki.org/do, ATTACHURL=http://svn.twiki.org/pub/Bugs/Item1271)
  • *URLPATH variables generate relative URLs (SCRIPTURLPATH=/do, ATTACHURLPATH=/pub/Bugs/Item1271)
Since ICONPATH is relative to %PUBURL, it is absolute and should be named ICONURL. If you wanted to be really consistent (orthogonal) you could add ICONURLPATH which would be based relative to PUBURLPATH instead of PUBURL.

CC

Crawford, you are right on the meaning of "orthogonal". Thank you for pointing this out. Not sure where I picked up this incorrect interpretation for "orthogonal", I will erase it from my vocabulary. Wondering though why nobody intervened earlier, I am using this word quite a lot...

So, what I meant, ICONPATH should be renamed to ICONURL to make it consistent with PUBURL, ATTACHURL and SCRIPTURL.

We could add a new ICONURLPATH, but I do not think we shoud do that, this is overkill.

-- PTh

Renamed ICONPATH should be renamed to ICONURL, SVN 8071.

-- PTh

Sorry, you are wrong about ICONURLPATH. If you are going to require consistency, then you need to be consistent in that requirement.

Added ICONURLPATH, and cleaned up the method locations and names (because it was doing my head in) SVN 8079

CC

smile Maybe Peters use of 'orthogonal' was inspired by the german term 'Orthogonaler Befehlssatz'.

FJ

Wrong or not on ICONURLPATH is a matter of opinion. I do not consider your opinion wrong, just different smile

Thanks for adding ICONURLPATH.

-- PTh

SVN 8081: Follow-up cleanup and bug fix of broken icon in breadcrumb.

-- PTh

ItemTemplate
Summary Rename ICONPATH{type} to ICONURL{type}
ReportedBy PeterThoeny
Codebase

SVN Range Fri, 30 Dec 2005 build 8037
AppliesTo Engine
Component

Priority Normal
CurrentState Closed
WaitingFor

Checkins 8071 8079 8080 8081
Edit | Attach | Watch | Print version | History: r15 < r14 < r13 < r12 < r11 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r15 - 2006-01-03 - PeterThoeny
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback