• Do not register here on develop.twiki.org, login with your twiki.org account.
• Use View topic Item7848 for generic doc work for TWiki-6.1.1. Use View topic Item7851 for doc work on extensions that are not part of a release. More... Close
• Anything you create or change in standard webs (Main, TWiki, Sandbox etc) will be automatically reverted on every SVN update.
Does this site look broken?. Use the LitterTray web for test cases.
In edit, click on "help" link of "Summary of changes". You end up with a topic does not exist message.

Also, the "help" in text Summary of changes help is a bit too intrusive. Better to show in a smaller font or to use an icon. Same for "help" of Force new revision help.

-- PTh


I agree that the first help link can be smaller. But the "new revision" help is already in smaller text.

A help icon would be more intrusive, unless I make a less obtrusive one smile

I do wonder why we are seeing the "Summary of changes" field. It appeared while I had not enabled the plugin. So I wonder if the IF check is correct.

AC

Breaking in on the IF check - it is faulty, should read something like

%IF{ "context RevCommentPluginEnabled" then="<p><label for='comment'>Summary of changes</label> <input class='twikiEditComment' type='text' style='width:50%' name='comment' id='comment' /> <a target='RevComment' onclick='return launchWindow(\"%TWIKIWEB%\",\"RevComment\")' href='#%MAKETEXT{"Opens page in new window"}%' title='' >%MAKETEXT{"help"}%</a><br /></p>" else=""}%

The same correction needs to be done in preview (pattern+classic)

SP

Committed correct IF check for RevCommentPlugin; leaving aesthetics untouched.

SVN 8169.

SP

ItemTemplate
Summary Help topic missing for "Summary of changes" help link
ReportedBy PeterThoeny
Codebase

SVN Range Tue, 27 Dec 2005 build 7999
AppliesTo Extension
Component RevCommentPlugin
Priority Normal
CurrentState Closed
WaitingFor

Checkins 8169
TargetRelease n/a
ReleasedIn 4.0.0
Edit | Attach | Watch | Print version | History: r7 < r6 < r5 < r4 < r3 | Backlinks | Raw View | Raw edit | More topic actions
Topic revision: r7 - 2008-01-31 - KennethLavrsen
 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2018 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback